Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorial for the new version #278

Merged
merged 8 commits into from
Jun 9, 2024
Merged

Update tutorial for the new version #278

merged 8 commits into from
Jun 9, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Jun 7, 2024 •
edited
Loading

Description

  1. Re-organize the section order in the tutorial.
  2. Add AgentScope Studio section in tutorial.
  3. Add project parameters in each example to fit AgentScope Studio.

Note: This PR should be merged after the AgentScope Studio PR, but is ready for review now!

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

rayrayraykk
rayrayraykk reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a minor question: which PR contains the update of README file in web dir?

@DavdGao
Copy link
Collaborator Author

DavdGao commented Jun 9, 2024 •
edited
Loading

LGTM, but a minor question: which PR contains the update of README file in web dir?

Update in the studio section.

pan-x-c
pan-x-c reviewed Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments, others LGTM

README.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
pan-x-c
pan-x-c approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 2f94c01 into modelscope:main Jun 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayraykk rayrayraykk rayrayraykk left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

@zhijianma zhijianma Awaiting requested review from zhijianma

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavdGao @pan-x-c @rayrayraykk