Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Add unit test and fix import error of LlamaIndexKnowledge #289

Merged
merged 5 commits into from
Jun 13, 2024
Merged

[Hotfix] Add unit test and fix import error of LlamaIndexKnowledge #289

merged 5 commits into from
Jun 13, 2024

Conversation

ZiTao-Li
Copy link
Collaborator

@ZiTao-Li ZiTao-Li commented Jun 13, 2024 •
edited
Loading

name: Add unit test for LlamaIndexKnowledge
about: Create a pull request

Description

  • remove ImportErrorReporter in the rag module, to avoid errors happened in typing check
  • adding a unit test for the LlamaIndexKnowledge, to ensure related packages has been installed correctly
  • fixed llamaindex version to a older one, aligned with the example

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@ZiTao-Li ZiTao-Li changed the title Add unit test for LlamaIndexKnowledge Add unit test and fix import error of LlamaIndexKnowledge Jun 13, 2024
@ZiTao-Li ZiTao-Li changed the title Add unit test and fix import error of LlamaIndexKnowledge [Hotfix] Add unit test and fix import error of LlamaIndexKnowledge Jun 13, 2024
DavdGao
DavdGao reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please test the basic conversation example in a pure python 3.11 environment with pip install -e . and pip install -e .\[full\] (for macos)

@DavdGao DavdGao added the bug Something isn't working label Jun 13, 2024
@DavdGao DavdGao linked an issue Jun 13, 2024 that may be closed by this pull request
[Bug]: In windows, there are some conflicts in the llama-index libraries. #287
Closed
@DavdGao DavdGao merged commit 479f7e7 into modelscope:main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@FredericW FredericW Awaiting requested review from FredericW

@qbc2016 qbc2016 Awaiting requested review from qbc2016

@zhijianma zhijianma Awaiting requested review from zhijianma

@xieyxclack xieyxclack Awaiting requested review from xieyxclack

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

Assignees
No one assigned
Labels
bug Something isn't working ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: In windows, there are some conflicts in the llama-index libraries.
2 participants
@ZiTao-Li @DavdGao