Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Remove notebook directory and fix typos. #330

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[HOTFIX] Remove notebook directory and fix typos. #330

merged 2 commits into from
Jul 12, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Jul 11, 2024 •
edited
Loading

Description

  1. Remove notebook directory
  2. Fix typos in the example of basic conversation

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao added documentation Improvements or additions to documentation ready for review labels Jul 11, 2024
pan-x-c
pan-x-c approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit bef70d9 into modelscope:main Jul 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-x-c pan-x-c pan-x-c approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavdGao @pan-x-c