Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix bug in DictDialogAgent #342

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Jul 16, 2024

Description

  • Fix the bug in DictDialogAgent

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao linked an issue Jul 16, 2024 that may be closed by this pull request
@DavdGao DavdGao requested review from pan-x-c and ZiTao-Li July 16, 2024 04:11
@DavdGao DavdGao added bug Something isn't working ready for review labels Jul 16, 2024
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 22df4d2 into modelscope:main Jul 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: bug in DictDialogAgent when use_memory = False
2 participants