-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
集成Yi模型 #343
集成Yi模型 #343
Conversation
Please execute |
谢谢我已经根据要求修改了相关格式和代码,可以继续接下的工作了 |
Hi @DavdGao, could you please help me review this? |
Thanks for your contribution. We will give feedback as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments, and does the yi API support streaming mode? Maybe we can add streaming mode in this PR as well.
Please complete the following section:
|
I've updated the code according to the rules, thank you @DavdGao @zhijianma. I'm unsure about the best place to put the demo and UnitTest. Would you mind advising where they should go? |
You can refer to https://github.com/modelscope/agentscope/pull/181/files to review the required changes. Demo, unitTest and documents are required. |
Please review and improve your code, please refer to
|
# Conflicts: # src/agentscope/models/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
name: 集成Yi模型
about: Create a pull request
Description
你好👋,我在你们的model里面集成了Yi模型,修改了init文件
Checklist
Please check the following items before code is ready to be reviewed.