Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online workstation #345

Merged
merged 31 commits into from
Aug 13, 2024
Merged

Online workstation #345

merged 31 commits into from
Aug 13, 2024

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Jul 16, 2024 •
edited
Loading

You must set the following vars in .env:

SECRET_KEY=****
SESSION_TYPE==****
IP==****
PORT==****
COPILOT_IP==****
COPILOT_PORT==****
CLIENT_ID==****
OWNER==****
REPO==****
USER_FILE_NAME==****
OSS_ENDPOINT==****
OSS_BUCKET_NAME==****
OSS_ACCESS_KEY_ID==****
OSS_ACCESS_KEY_SECRET==****
CLIENT_SECRET==****
LOCAL_WORKSTATION==****

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@rayrayraykk rayrayraykk changed the title Online workstation [WIP]Online workstation Jul 29, 2024
@rayrayraykk rayrayraykk changed the title [WIP]Online workstation Online workstation Jul 29, 2024
qbc2016
qbc2016 reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pan-x-c
pan-x-c reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments, others LGTM

src/agentscope/studio/_app_online.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
DavdGao
DavdGao reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

setup.py Show resolved Hide resolved
src/agentscope/studio/utils.py Outdated Show resolved Hide resolved
qbc2016
qbc2016 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qbc2016 qbc2016 merged commit 56e6b50 into modelscope:main Aug 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-x-c pan-x-c pan-x-c left review comments

@DavdGao DavdGao DavdGao left review comments

@qbc2016 qbc2016 qbc2016 approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rayrayraykk @qbc2016 @pan-x-c @DavdGao