Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify message related typing in AgentScope into Msg rather than dict #386

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Aug 6, 2024

Description

  • This PR is the pre-work of serialization/deserialization
  • Unify the message related typing in AgentScope into Msg rather than dict.

Note

@qbc2016 This PR has changed the logic within the function log_gradio, please check if the change is correct.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao changed the title Unify the typing in AgentScope into Msg rather than dict Unify message related typing in AgentScope into Msg rather than dict Aug 6, 2024
@DavdGao DavdGao requested review from qbc2016, ZiTao-Li and pan-x-c and removed request for ZiTao-Li August 6, 2024 04:12
@DavdGao DavdGao added ready for review enhancement New feature or request labels Aug 6, 2024
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DavdGao DavdGao merged commit dcb7c8b into modelscope:main Aug 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants