Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deprecated load_model_by_config_name in the nl2sql example #415

Merged
merged 38 commits into from
Aug 22, 2024

Conversation

garyzhang99
Copy link
Collaborator

@garyzhang99 garyzhang99 commented Aug 21, 2024


name: Pull Request
about: Create a pull request

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

wenhao and others added 30 commits February 22, 2024 14:51
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and in the future we should expose the function in agentscope.get_model_by_config_name()

@DavdGao DavdGao merged commit 67e734d into modelscope:main Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants