Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize launcher of RPCAgent #47

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Optimize launcher of RPCAgent #47

merged 4 commits into from
Mar 11, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Mar 4, 2024 •
edited
Loading

Optimize launcher of RPCAgent

Description

  1. Optimize the stop method of rpc server to avoid resource leakage
  2. Support starting rpc server in thread mode

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the enhancement New feature or request label Mar 4, 2024
@pan-x-c pan-x-c self-assigned this Mar 4, 2024
DavdGao
DavdGao reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Plz ensure if we need to modify distributed examples.

DavdGao
DavdGao approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DavdGao
DavdGao approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add more docstring for in_subprocess for developers.

@pan-x-c pan-x-c merged commit 473d6c6 into modelscope:main Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

Assignees

@pan-x-c pan-x-c

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-x-c @DavdGao