Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced distributed debate example to support multiple users #68

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Enhanced distributed debate example to support multiple users #68

merged 10 commits into from
Mar 14, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Mar 14, 2024 •
edited
Loading

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the enhancement New feature or request label Mar 14, 2024
@pan-x-c pan-x-c mentioned this pull request Mar 14, 2024
Closed
ZiTao-Li
ZiTao-Li reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor inline comments

examples/distributed/README.md Show resolved Hide resolved
examples/distributed/distributed_debate.py Show resolved Hide resolved
rayrayraykk
rayrayraykk approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit c493416 into modelscope:main Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 left review comments

@ZiTao-Li ZiTao-Li ZiTao-Li left review comments

@rayrayraykk rayrayraykk rayrayraykk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pan-x-c @qbc2016 @rayrayraykk @ZiTao-Li