Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in agent when use_memory is False #74

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Mar 15, 2024

Description

  • Fix the error when self.memory is None in reply function.
  • Disable the default value of model_config_name of built-in agents, so that a model must be provided when using agent.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

…one` of `model_config_name` to avoid error
@DavdGao DavdGao requested a review from ZiTao-Li March 15, 2024 08:38
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 30a3f44 into modelscope:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants