Adding web page digest function to service module #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavdGao
reviewed
Mar 19, 2024
There was a problem hiding this comment.
- Since there's no overlap in the processes for handling web pages via a model and a third-party library, they should be split into two separate methods like
bing_searchandgoogle_search. The developer should decide which to use when choosing the service function. - Please see inline comments.
pan-x-c
reviewed
Mar 22, 2024
# Conflicts: # src/agentscope/service/text_processing/summarization.py
pan-x-c
reviewed
Mar 25, 2024
pan-x-c
reviewed
Mar 25, 2024
pan-x-c
reviewed
Mar 25, 2024
pan-x-c
reviewed
Mar 26, 2024
DavdGao
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Please see inline comments, and solve the conflicts.
Ps:
We need to determine if we want developers to use the parse_html function directly. If so:
- The arguments
keep_rawandhtml_parse_funcinparse_htmlfunction are meaningless for developers when they useparse_htmlfunction directly. - The "return raw" and "parse html by customized function" operations should be handled within the
load_webfunction.
# Conflicts: # src/agentscope/service/text_processing/summarization.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding web page digest function to service module
Description
As there are some recent internal requests about parsing the webpage, this PR introduce a webpage digestion service method to the framework.
If a LLM is provided as the
modelparameter, the webpage will first be split (by langchain_text_splitters.HTMLHeaderTextSplitter) and analyzed by LLM one by one.If there is no LLM provide, then the langchain_community.document_transformers.BeautifulSoupTransformer will be used to clean the webpage.
Checklist
Please check the following items before code is ready to be reviewed.