Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/bad data exhibition #195

Merged
merged 18 commits into from
Feb 7, 2024
Merged

Docs/bad data exhibition #195

merged 18 commits into from
Feb 7, 2024

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Jan 23, 2024

As the title says.

@HYLcool HYLcool linked an issue Jan 23, 2024 that may be closed by this pull request
[docs] construct the "bad" data exhibition #192
Closed
@HYLcool HYLcool self-assigned this Jan 23, 2024
@HYLcool HYLcool added the documentation Improvements or additions to documentation label Jan 23, 2024
yxdyc
yxdyc reviewed Jan 24, 2024
View reviewed changes
docs/BadDataExhibition_ZH.md Outdated Show resolved Hide resolved
docs/BadDataExhibition_ZH.md Outdated Show resolved Hide resolved
docs/BadDataExhibition.md Show resolved Hide resolved
@HYLcool
Copy link
Collaborator Author

HYLcool commented Jan 24, 2024 •
edited
Loading

  • add "bad" data examples from the analysis result of MMC4 dataset for these 2 docs.

yxdyc
yxdyc approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The todo item can be finished in next PR:
[add "bad" data examples from the analysis result of MMC4 dataset for these 2 docs. ]

@HYLcool
Copy link
Collaborator Author

HYLcool commented Feb 5, 2024

  • "Bad" data examples from MMC4 have been added to the exhibition
  • Fix bugs for mmc4_to_dj/dj_to_mmc4 tools: there might be multiple images matching the same sentence, so we need to support adding multiple image_special_tokens to the same sentence in mmc4_to_dj and parsing them correctly in dj_to_mmc4.

@HYLcool HYLcool requested a review from yxdyc February 6, 2024 11:12
yxdyc
yxdyc approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications lgtm.

@HYLcool HYLcool mentioned this pull request Feb 7, 2024
Merged
@HYLcool HYLcool merged commit 43be23f into main Feb 7, 2024
5 checks passed
@HYLcool HYLcool deleted the docs/bad_data_exhibition branch February 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@drcege drcege Awaiting requested review from drcege

@chenhesen chenhesen Awaiting requested review from chenhesen

@BeachWang BeachWang Awaiting requested review from BeachWang

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees

@HYLcool HYLcool

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] construct the "bad" data exhibition
2 participants
@HYLcool @yxdyc