Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* fix several bugs #301

Merged
merged 3 commits into from
Apr 19, 2024
Merged

* fix several bugs #301

merged 3 commits into from
Apr 19, 2024

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Apr 18, 2024 •
edited
Loading

  • for "undefined opencc" bug for chinese_convert_mapper
  • undefined punctuation_pattern in simhash/minhash deduplicators.

@HYLcool HYLcool added the bug Something isn't working label Apr 18, 2024
@HYLcool HYLcool self-assigned this Apr 18, 2024
@HYLcool HYLcool changed the title * fix for "undefined opencc" bug for chinese_convert_mapper * fix several bugs Apr 19, 2024
yxdyc
yxdyc approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxdyc yxdyc merged commit 6e0e6e7 into main Apr 19, 2024
4 checks passed
@HYLcool HYLcool deleted the fix/undefined_opencc branch April 19, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@drcege drcege Awaiting requested review from drcege

@chenhesen chenhesen Awaiting requested review from chenhesen

@BeachWang BeachWang Awaiting requested review from BeachWang

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees

@HYLcool HYLcool

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HYLcool @yxdyc