Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixed: params from base class can't be parsed in some OPs #311

Merged
merged 1 commit into from
May 8, 2024
Merged

bug fixed: params from base class can't be parsed in some OPs #311

merged 1 commit into from
May 8, 2024

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented May 8, 2024

By the way, a new test case is added to test param parsing

@HYLcool HYLcool added the bug Something isn't working label May 8, 2024
@HYLcool HYLcool self-assigned this May 8, 2024
@HYLcool HYLcool requested review from drcege and yxdyc May 8, 2024 09:55
yxdyc
yxdyc approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Explanation: The modified parts originally cause assertion error for an constant node in AST building, we fix this problem in this PR

@HYLcool HYLcool merged commit 6b6d9e0 into main May 8, 2024
4 checks passed
@HYLcool HYLcool deleted the fix/base_class_params_parsing_failed branch May 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@drcege drcege Awaiting requested review from drcege

Assignees

@HYLcool HYLcool

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HYLcool @yxdyc