Trust remote code param #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model_utils中的prepare_simple_aesthetics_model和prepare_diffusion_model分别使用了simple-aesthetics-predictor和diffusers库，二者也是基于transformers开发的，会使用transformers下载模型。
在 #382 中，我提交了对算子的trust_remote_code参数支持，解决了算子无法接受trust_remote_code参数的问题。
算子接受trust_remote_code后会传递给prepare_model，其中prepare_huggingface_model有trust_remote_code参数入口，但是prepare_simple_aesthetics_model和prepare_diffusion_model没有trust_remote_code参数入口，这可能会导致与之相关的美学评分算子和diffusion算子出bug。因此，本次PR修正了这两个函数。