Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready] support API retry #479

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[Ready] support API retry #479

merged 3 commits into from
Nov 11, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Nov 8, 2024

  • Use OpenAI's client.post to be compatibility with OpenAI, Dashscope, etc., while allowing for customizable API endpoints.
  • All parameters supported by OpenAI are accepted, such as timeout, max_retries, etc., which can be passed through the model_params parameter of the operator.
  • Add mocked API unit tests.

@drcege drcege marked this pull request as ready for review November 11, 2024 02:30
@drcege drcege changed the title support api retry support API retry Nov 11, 2024
@drcege drcege self-assigned this Nov 11, 2024
@drcege drcege added the enhancement New feature or request label Nov 11, 2024
@drcege drcege changed the title support API retry [Ready] support API retry Nov 11, 2024
Copy link
Collaborator

@BeachWang BeachWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeachWang BeachWang merged commit 898372d into main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants