Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added auto-HPO feature with WandB #65

Merged
merged 6 commits into from
Nov 8, 2023
Merged

added auto-HPO feature with WandB #65

merged 6 commits into from
Nov 8, 2023

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Nov 8, 2023 •
edited
Loading

As the title says, related to #47

  • The core modifications are in tools/hpo, and data_juicer/config.py
  • The others are from pre-commit auto-modification (isort, yapf, ......)

@yxdyc
added auto-HPO feature with WandB
6951904
@yxdyc
added auto-HPO feature with WandB.
4101678 
- The core modifications are in tools/hpo, and data_juicer/config.py.
- The others are from pre-commit run
@yxdyc yxdyc requested a review from HYLcool November 8, 2023 04:09
@yxdyc yxdyc added the enhancement New feature or request label Nov 8, 2023
@yxdyc yxdyc requested a review from zhijianma November 8, 2023 04:11
@HYLcool HYLcool linked an issue Nov 8, 2023 that may be closed by this pull request
Auto-HPO是全流程自动化的还是需要人工介入 #47
Closed
3 tasks
HYLcool
HYLcool reviewed Nov 8, 2023
View reviewed changes
tools/hpo/README.md Outdated Show resolved Hide resolved
HYLcool
HYLcool reviewed Nov 8, 2023
View reviewed changes
tools/hpo/README.md Outdated Show resolved Hide resolved
HYLcool
HYLcool reviewed Nov 8, 2023
View reviewed changes
tools/hpo/README_ZH.md Outdated Show resolved Hide resolved
HYLcool
HYLcool reviewed Nov 8, 2023
View reviewed changes
tools/hpo/README_ZH.md Outdated Show resolved Hide resolved
@yxdyc
Copy link
Collaborator Author

yxdyc commented Nov 8, 2023

Fixed the comments by @HYLcool , you can track the modifications in these commits: this and this.

HYLcool
HYLcool approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@yxdyc yxdyc merged commit e18292a into main Nov 8, 2023
3 checks passed
@zhijianma zhijianma deleted the feat/hpo branch November 15, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool approved these changes

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees

@yxdyc yxdyc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-HPO是全流程自动化的还是需要人工介入
2 participants
@yxdyc @HYLcool