fix: support gradio 4.35.0 in mgr.load (#23)

modelscope · Jun 13, 2024 · a10188e · a10188e
1 parent d2e24dc
commit a10188e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.changeset/wicked-stingrays-marry.md b/.changeset/wicked-stingrays-marry.md
@@ -0,0 +1,5 @@
+---
+'modelscope_studio': patch
+---
+
+fix: support gradio 4.35.0 in mgr.load
diff --git a/backend/modelscope_studio/external.py b/backend/modelscope_studio/external.py
@@ -270,10 +270,13 @@ def from_spaces_blocks(
     try:
         space = f"{_endpoint}/api/v1/studio/{space_name}/gradio/"
         kwargs = {}
-        if version.Version(gradio.__version__) > version.Version('4.19.1'):
-            kwargs["upload_files"] = False
+        if version.Version(gradio.__version__) > version.Version('4.35.0'):
+            kwargs["download_files"] = False
+            kwargs["_skip_components"] = False
+        elif version.Version(gradio.__version__) > version.Version('4.19.1'):
             kwargs["download_files"] = False
             kwargs["_skip_components"] = False
+            kwargs["upload_files"] = False
         elif version.Version(gradio.__version__) == version.Version('4.19.1'):
             kwargs["download_files"] = False
         client = Client(
@@ -296,7 +299,9 @@ def from_spaces_blocks(
 
         # Use end_to_end_fn here to properly upload/download all files
         predict_fns = []
-        for fn_index, endpoint in enumerate(client.endpoints):
+
+        for fn_index, endpoint in enumerate(client.endpoints) if isinstance(
+                client.endpoints, list) else client.endpoints.items():
             if not isinstance(endpoint, Endpoint):
                 raise TypeError(
                     f"Expected endpoint to be an Endpoint, but got {type(endpoint)}"