fix: Moves ContextMenu out of core, streamlines code, fixes bugs

[kamronbatman]

Summary

• Removes allocation of a List<ContextMenuEntry> every time a context menu is created.
• Moves packet/context menu creation logic out of the core
• Fixes tame entry

BREAKING CHANGE

Important

Developer Note

public virtual void GetContextMenuEntries(Mobile from, List<ContextMenuEntry> list)

and similar functions changed to

public virtual void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)

[github-actions]

Qodana for .NET

3 new problems were found

Inspection name	Severity	Problems
Namespace does not correspond to file location	◽️ Notice	3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency	Version	Licenses
Argon2.Bindings	1.16.1	MIT
BouncyCastle.Cryptography	2.4.0	MIT
CommunityToolkit.HighPerformance	8.2.2	MIT
LibDeflate.Bindings	1.0.2.120	GPL-3.0-only
MailKit	4.7.1.1	MIT
Microsoft.Extensions.FileSystemGlobbing	8.0.0	MIT
MimeKit	4.7.1	MIT
ModernUO.Serialization.Annotations	2.9.1	GPL-3.0-only
ModernUO.Serialization.Generator	2.11.3	GPL-3.0-only
Nerdbank.GitVersioning	3.6.139	MIT
PollGroup	1.5.1	BSD-3-Clause
Serilog.Sinks.Async	2.0.0	Apache-2.0
Serilog.Sinks.Console	6.0.0	Apache-2.0
Serilog	4.0.0	Apache-2.0
System.Formats.Asn1	8.0.1	MIT
System.IO.Hashing	8.0.0	MIT
System.Security.Cryptography.Pkcs	8.0.0	MIT
Zstd.Binaries	1.6.0	MIT

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions