Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Converts ResurrectGump to Static/Dynamic Gumps #1904

Merged
merged 13 commits into from
Aug 7, 2024

Conversation

IcculusC
Copy link
Contributor

@IcculusC IcculusC commented Aug 6, 2024

Looked into migrating the ResurrectionGump.

It turns out that it covers both the regular use and a special RunUO gump for the PricedHealer. Therefore I split it into two new StaticGump implementations. They share much of the same logic in their response handler, and I'm open to suggestions for how to abstract that out.

@IcculusC IcculusC requested a review from kamronbatman August 6, 2024 00:39
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 6, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.2.2 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.7.1.1 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.7.1 MIT
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.139 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.1 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

IcculusC and others added 3 commits August 5, 2024 20:56
a few formatting/simplification suggestions from Kam

Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
@IcculusC IcculusC marked this pull request as ready for review August 6, 2024 01:09
@IcculusC IcculusC force-pushed the migrate-resurrection-gump branch from 67368dc to a90c226 Compare August 6, 2024 01:49
@kamronbatman kamronbatman changed the title migrate resurrection gump fix: Converts ResurrectGump to Static/Dynamic Gumps Aug 6, 2024
@kamronbatman kamronbatman merged commit 9014f3d into main Aug 7, 2024
14 checks passed
@kamronbatman kamronbatman deleted the migrate-resurrection-gump branch August 7, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants