-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Converts ResurrectGump to Static/Dynamic Gumps #1904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamronbatman
reviewed
Aug 6, 2024
kamronbatman
reviewed
Aug 6, 2024
kamronbatman
reviewed
Aug 6, 2024
kamronbatman
reviewed
Aug 6, 2024
a few formatting/simplification suggestions from Kam Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
IcculusC
force-pushed
the
migrate-resurrection-gump
branch
from
August 6, 2024 01:49
67368dc
to
a90c226
Compare
kamronbatman
changed the title
migrate resurrection gump
fix: Converts ResurrectGump to Static/Dynamic Gumps
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked into migrating the
ResurrectionGump
.It turns out that it covers both the regular use and a special RunUO gump for the
PricedHealer
. Therefore I split it into two newStaticGump
implementations. They share much of the same logic in their response handler, and I'm open to suggestions for how to abstract that out.