Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes networking issues #1958

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Sep 19, 2024

Summary

  • Puts back EventSink.SocketConnect.
  • Reverts networking change to push the networking to a separate thread.
  • Reverts changes to the firewall by removing the firewall queue.
  • Fixes listeners not shutting down with the server.
  • Fixes race condition causing connections to get stuck even after they are disposed.

Note

Developer Note
Networking has been reverted back to using the main thread instead of a background thread. This alleviated complexity and the requirement for concurrent queues all over the place.

Copy link

github-actions bot commented Sep 19, 2024

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Namespace does not correspond to file location ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 20 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.3.0 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.7.1.1 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.7.1 MIT
ModernUO.CodeGeneratedEvents.Annotations 1.0.0 GPL-3.0-only
ModernUO.CodeGeneratedEvents.Generator 1.0.3.2 GPL-3.0-only
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.143 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.1 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@kamronbatman kamronbatman force-pushed the kbatman/fix_networking_revert branch from fe3f895 to 05948fe Compare September 19, 2024 21:30
@kamronbatman kamronbatman merged commit e0fcde8 into main Sep 19, 2024
12 of 13 checks passed
@kamronbatman kamronbatman deleted the kbatman/fix_networking_revert branch September 19, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant