Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixes beneficial notoriety checks and adds better young restrictions/messaging #2000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Nov 27, 2024

Summary

  • Adds As a young player, you may not use beneficial skills on older players. for healing.
  • Adds You cannot steal from people or monsters right now. Practice on chests and barrels. for stealing.
  • Adds fix to prevent stealing from young players with the message You cannot steal from the Young.
  • Adds As a young player, you may not cast beneficial spells onto older players. for beneficial spells.
  • Fixes stealing heavy items error message to This item is too heavy to steal from someone's backpack.
  • Fixes notoriety issue where young players cannot heal their own horse.
  • Fixes notoriety issue where pets bypass beneficial checks in some circumstances.

Copy link

github-actions bot commented Nov 27, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 20 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.3.2 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.8.0 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.8.0 MIT
ModernUO.CodeGeneratedEvents.Annotations 1.0.0 GPL-3.0-only
ModernUO.CodeGeneratedEvents.Generator 1.0.3.2 GPL-3.0-only
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.143 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.2 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@kamronbatman kamronbatman changed the title feat: Adds better young restrictions and messaging feat: Fixes beneficial notoriety checks and adds better young restrictions/messaging Nov 27, 2024
@kamronbatman kamronbatman force-pushed the kbatman/young_restrictions branch 2 times, most recently from 97c6c67 to b4b284b Compare November 27, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant