Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for serialise/deserialise tests #2483

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Oct 16, 2023

These keep flaking on CI on Windows which makes them kind of useless. A quick fix for us is to just increase the timeout.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 186e58f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koddsson
Copy link
Contributor Author

I have no idea why this would start failing. I'll try to just increase the timeout instead.

@koddsson koddsson changed the title skip serialise/deserialise tests on windows Increase timeout for serialise/deserialise tests Oct 16, 2023
@koddsson koddsson merged commit d0959dc into modernweb-dev:master Oct 16, 2023
5 checks passed
@koddsson koddsson deleted the skip-flaky-test-in-windows branch October 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant