Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Webdriver launcher to setViewportPlugin #2850

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

web-padawan
Copy link
Contributor

What I did

Fixes #1072

  1. Added setWindowSize() to Webdriver launcher (only in "SessionManager" used with concurrency: 1)
  2. Updated setViewportPlugin() to use the new setWindowSize() API with Webdriver launcher

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: f5e3078

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@web/test-runner-webdriver Minor
@web/test-runner-commands Minor
@web/test-runner-browserstack Patch
@web/test-runner-saucelabs Patch
@web/test-runner-visual-regression Patch
@web/test-runner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@web-padawan
Copy link
Contributor Author

UPD: this API produces unexpected results so we should upgrade WebdriverIO to v9 and use setViewport() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-runner-commands] Add Webdriver support for setViewportSize command
1 participant