Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release 3.4.1 reset #1859

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Post release 3.4.1 reset #1859

merged 3 commits into from
Jun 29, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jun 29, 2023

Reinitialize develop from master and reset version to 3.dev4 following release of 3.4.1

@wpbonelli wpbonelli force-pushed the post-release-3.4.1-reset branch from faed041 to 7014486 Compare June 29, 2023 15:01
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1859 (7014486) into develop (5190394) will increase coverage by 0.0%.
The diff coverage is 80.0%.

@@           Coverage Diff           @@
##           develop   #1859   +/-   ##
=======================================
  Coverage     72.2%   72.3%           
=======================================
  Files          256     256           
  Lines        56120   56112    -8     
=======================================
+ Hits         40561   40575   +14     
+ Misses       15559   15537   -22     
Impacted Files Coverage Δ
flopy/mf6/modflow/mfems.py 77.7% <ø> (ø)
flopy/mf6/modflow/mfgnc.py 92.0% <ø> (ø)
flopy/mf6/modflow/mfgwf.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfapi.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfbuy.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfchd.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfcsub.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfdis.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfdisu.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfdisv.py 100.0% <ø> (ø)
... and 62 more

... and 4 files with indirect coverage changes

@wpbonelli wpbonelli merged commit a644b52 into develop Jun 29, 2023
@wpbonelli wpbonelli deleted the post-release-3.4.1-reset branch June 29, 2023 15:41
@mwtoews
Copy link
Contributor

mwtoews commented Jun 30, 2023

Similar comment to MODFLOW-USGS/modflow6#1283 this should be 3.4.2.dev0.

Also, the post-release version from 3.4.0 would normally be 3.4.0.post0. But 3.4.1 is not a big deal. The difference between a micro increment vs post-release is not always obvious. (Often it's just a packaging difference). The micro increment was actually fine, since it includes a bug fix. Versions are cheap to make!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants