Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark tests needing geopandas, remove pytest-cases dependency #2077

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jan 31, 2024

  • reformat python files with updated black (version 24) done in update(contour_array): add tri_mask kwarg to parameters #2078, but this PR also reformats a few missed autotests and notebooks
  • mark tests requiring geopandas
  • add .DS_Store mac files to .gitignore
  • remove pytest-cases test dependency (not compatible yet with pytest 8)
    • refactor test_grid.py and test_grid_cases.py
    • refactor test_mp6.py

This PR originally contained updates to examples/data/, these have been moved to #2084

@wpbonelli wpbonelli changed the title refactor(examples): refactor(examples): consolidate example data, rerun black, mark tests Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92853a9) 73.0% compared to head (6cef000) 72.9%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2077     +/-   ##
=========================================
- Coverage     73.0%   72.9%   -0.1%     
=========================================
  Files          259     259             
  Lines        59329   57952   -1377     
=========================================
- Hits         43332   42269   -1063     
+ Misses       15997   15683    -314     

see 78 files with indirect coverage changes

* consolidate test005_advgw_tidal data dir
* remove unused mf2k_test dir
* update .gitignore
* rename lak1b_bath.txt -> l1b2k_bath.txt
* update l1b2k_bath.nam
* remove unused mppth/mpend files
* mark tests requiring geopandas
* remove pytest-cases from testing dependencies
* refactor mp6 tests without pytest-cases
* refactor grid tests without pytest-cases
@wpbonelli wpbonelli marked this pull request as ready for review February 1, 2024 01:37
@wpbonelli wpbonelli changed the title refactor(examples): consolidate example data, rerun black, mark tests refactor(examples): consolidate example data, mark tests Feb 1, 2024
@wpbonelli wpbonelli changed the title refactor(examples): consolidate example data, mark tests test: mark tests needing geopandas, remove pytest-cases dependency Feb 1, 2024
@wpbonelli wpbonelli merged commit d0c5dbc into modflowpy:develop Feb 1, 2024
24 checks passed
@wpbonelli wpbonelli deleted the exampledata branch February 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants