-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrame.prod after transpose on Windows results in incorrect result #1119
Labels
bug 🦗
Something isn't working
pandas concordance 🐼
Functionality that does not match pandas
Windows 🖥️
Issues for Windows users
Milestone
Comments
devin-petersohn
added
bug 🦗
Something isn't working
pandas concordance 🐼
Functionality that does not match pandas
Windows 🖥️
Issues for Windows users
labels
Mar 2, 2020
6 tasks
devin-petersohn
added a commit
to devin-petersohn/modin
that referenced
this issue
Jul 24, 2020
…me.prod` Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm
pushed a commit
that referenced
this issue
Jul 24, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@devin-petersohn are you sure this is fixed? I see the same issue hitting CI, for example here: https://github.com/modin-project/modin/pull/1801/checks?check_run_id=908354983 |
I am not sure. There were some CI issues yesterday so #1801 may have been merged by mistake. |
Reverted commit. |
aregm
pushed a commit
to aregm/modin
that referenced
this issue
Sep 16, 2020
…me.prod` (modin-project#1801) Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm
pushed a commit
to aregm/modin
that referenced
this issue
Sep 16, 2020
…`DataFrame.prod`" (modin-project#1813) This reverts commit d8a9972.
Looks like we're no longer skipping the
So I'll close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🦗
Something isn't working
pandas concordance 🐼
Functionality that does not match pandas
Windows 🖥️
Issues for Windows users
System information
modin.__version__
): 0.7.1+4.ga39d66aDescribe the problem
Recently with #1081, a new behavior has emerged caused by updating pandas. For
DataFrame.prod
in Windows, pytest will generate incorrect numbers fordf.T.prod
. This can be reproduced by running the tests after removing the@pytest.markskipif
command on these lines:modin/modin/pandas/test/test_dataframe.py
Lines 3214 to 3217 in a39d66a
modin/modin/pandas/test/test_dataframe.py
Lines 3269 to 3272 in a39d66a
Note that this is only happening on
prod
and on Windows.The text was updated successfully, but these errors were encountered: