Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.prod after transpose on Windows results in incorrect result #1119

Closed
devin-petersohn opened this issue Mar 2, 2020 · 4 comments · Fixed by #1801
Closed

DataFrame.prod after transpose on Windows results in incorrect result #1119

devin-petersohn opened this issue Mar 2, 2020 · 4 comments · Fixed by #1801
Labels
bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas Windows 🖥️ Issues for Windows users
Milestone

Comments

@devin-petersohn
Copy link
Collaborator

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows only
  • Modin version (modin.__version__): 0.7.1+4.ga39d66a
  • Python version: All
  • Code we can use to reproduce:

Describe the problem

Recently with #1081, a new behavior has emerged caused by updating pandas. For DataFrame.prod in Windows, pytest will generate incorrect numbers for df.T.prod. This can be reproduced by running the tests after removing the @pytest.markskipif command on these lines:

@pytest.mark.skipif(
os.name == "nt",
reason="Windows has a memory issue for large numbers on this test",
)

@pytest.mark.skipif(
os.name == "nt",
reason="Windows has a memory issue for large numbers on this test",
)

Note that this is only happening on prod and on Windows.

@devin-petersohn devin-petersohn added bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas Windows 🖥️ Issues for Windows users labels Mar 2, 2020
@devin-petersohn devin-petersohn added this to the 0.8.0 milestone Jul 24, 2020
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jul 24, 2020
…me.prod`

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit that referenced this issue Jul 24, 2020
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@vnlitvinov
Copy link
Collaborator

@devin-petersohn are you sure this is fixed? I see the same issue hitting CI, for example here: https://github.com/modin-project/modin/pull/1801/checks?check_run_id=908354983

@devin-petersohn
Copy link
Collaborator Author

I am not sure. There were some CI issues yesterday so #1801 may have been merged by mistake.

@devin-petersohn
Copy link
Collaborator Author

Reverted commit.

@devin-petersohn devin-petersohn modified the milestones: 0.8.0, 0.8.1 Jul 29, 2020
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
…me.prod` (modin-project#1801)

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@Garra1980 Garra1980 modified the milestones: 0.8.1, Someday Sep 22, 2020
@mvashishtha
Copy link
Collaborator

Looks like we're no longer skipping the prod test even in the transposed cases:

So I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working pandas concordance 🐼 Functionality that does not match pandas Windows 🖥️ Issues for Windows users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants