Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to insert distributed columns at Pandas query compiler #1772

Closed
dchigarev opened this issue Jul 22, 2020 · 1 comment · Fixed by #2443
Closed

Add ability to insert distributed columns at Pandas query compiler #1772

dchigarev opened this issue Jul 22, 2020 · 1 comment · Fixed by #2443
Assignees
Labels
new feature/request 💬 Requests and pull requests for new features
Milestone

Comments

@dchigarev
Copy link
Collaborator

For now, there is no way to insert one or multiple columns in a dataframe at a specific location if you are working at the query compiler level, without materializing column and passing it into insert.

@dchigarev dchigarev added the new feature/request 💬 Requests and pull requests for new features label Jul 22, 2020
@dchigarev dchigarev self-assigned this Jul 22, 2020
dchigarev added a commit to dchigarev/modin that referenced this issue Jul 22, 2020
… pandas query compiler

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@devin-petersohn
Copy link
Collaborator

I agree, this can use something better than what we have. Right now, I would say use concat:

return query_compiler.get_column_array(self.columns[:loc]).concat(1, new_value).concat(1, query_compiler.get_column_array(self.columns[loc:]))

No guarantee on it working as I wrote it 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
2 participants