Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

df_equals sorts column labels before frame assertion #1784

Closed
dchigarev opened this issue Jul 23, 2020 · 0 comments · Fixed by #1896
Closed

df_equals sorts column labels before frame assertion #1784

dchigarev opened this issue Jul 23, 2020 · 0 comments · Fixed by #1896
Assignees
@dchigarev
Labels
bug 🦗 Something isn't working
Milestone
0.8.1

Comments

@dchigarev
Copy link
Collaborator

Currently we're sorting columns of two frames to check it for equality, this is a legacy behavior, we should remove that sort and fix all cases where assertion without sorting are not passing
@dchigarev dchigarev added the bug 🦗 Something isn't working label Jul 23, 2020
@dchigarev dchigarev mentioned this issue Jul 23, 2020
Merged
5 tasks
@dchigarev dchigarev self-assigned this Jul 23, 2020
@devin-petersohn devin-petersohn added this to the 0.8.1 milestone Jul 23, 2020
@dchigarev dchigarev mentioned this issue Aug 6, 2020
Merged
6 tasks
dchigarev added a commit to dchigarev/modin that referenced this issue Aug 20, 2020
@dchigarev
FIX-modin-project#1784: removed columns sort from 'df_equals'
b0fcf2f 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
YarShev pushed a commit that referenced this issue Aug 24, 2020
@dchigarev
FIX-#1784: removed columns sort from 'df_equals' (#1896)
5d59c99 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@dchigarev @aregm
FIX-modin-project#1784: removed columns sort from 'df_equals' (modin-…
1e1a773 
…project#1896)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
bug 🦗 Something isn't working
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

FIX-#1784: remove columns sorting from testing dchigarev/modin
2 participants
@devin-petersohn @dchigarev