Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine change callbacks should maintain order #1803

Closed
vnlitvinov opened this issue Jul 24, 2020 · 0 comments · Fixed by #1805
Closed

Engine change callbacks should maintain order #1803

vnlitvinov opened this issue Jul 24, 2020 · 0 comments · Fixed by #1805
Assignees
@vnlitvinov
Labels
new feature/request 💬 Requests and pull requests for new features
Milestone
0.8.0

Comments

@vnlitvinov
Copy link
Collaborator

Currently callbacks registered at Publisher (be it execution engine or partition format) are called in somewhat random order.
For certain functionality we need to make sure the "root" callback (the one that initializes the execution engine) in modin/__init__.py is always called first.
@vnlitvinov vnlitvinov added the new feature/request 💬 Requests and pull requests for new features label Jul 24, 2020
@vnlitvinov vnlitvinov added this to the 0.8.0 milestone Jul 24, 2020
@vnlitvinov vnlitvinov self-assigned this Jul 24, 2020
@vnlitvinov vnlitvinov mentioned this issue Jul 24, 2020
Merged
6 tasks
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 26, 2020
@vnlitvinov
FIX-modin-project#1803: Change the order of execution engine change c…
f94e875 
…allbacks

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
devin-petersohn pushed a commit that referenced this issue Jul 27, 2020
@vnlitvinov
FIX-#1803: Change the order of execution engine change callbacks (#1805)
a08c0c8 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@vnlitvinov @aregm
FIX-modin-project#1803: Change the order of execution engine change c…
853b55a 
…allbacks (modin-project#1805)

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vnlitvinov vnlitvinov

Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

FIX-#1803: Change the order of execution engine change callbacks vnlitvinov/modin
1 participant
@vnlitvinov