Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupby() with arbitrary Series in by list raises an error #1854

Closed
itamarst opened this issue Jul 29, 2020 · 2 comments · Fixed by #1886
Closed

groupby() with arbitrary Series in by list raises an error #1854

itamarst opened this issue Jul 29, 2020 · 2 comments · Fixed by #1886
Labels
bug 🦗 Something isn't working
Milestone

Comments

@itamarst
Copy link
Contributor

This is a follow-up on #1770, for the more complex case where the Series is not just an untouched Series from the DataFrame.

import pandas as pd
import modin.pandas as mpd

data = {
    "a": [1, 1, 2],
    "b": [11, 11, 22],
    "c": [111, 111, 222]
}

df = pd.DataFrame(data)
df = pd.concat([df])
ref = df.groupby(["a", "b", df["c"] + 1]).size()
print(ref)

df = mpd.DataFrame(data)
df = mpd.concat([df])
exp = df.groupby(["a", "b", df["c"] + 1]).size()
print(exp)

(The specific error raised will be different once #1842 is merged, but it errors out both before and after that PR.)

Originally reported by @ienkovich.

@itamarst itamarst added the bug 🦗 Something isn't working label Jul 29, 2020
@devin-petersohn devin-petersohn added this to the 0.8.1 milestone Jul 29, 2020
@itamarst
Copy link
Contributor Author

Will see if I can figure out this one too.

@itamarst
Copy link
Contributor Author

I've gotten size() working, but... it seems like there's more broad need for code, e.g. __iter__ breaks. So will move on to that and see what else is broken too.

itamarst added a commit to itamarst/modin that referenced this issue Jul 30, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Jul 31, 2020
…ies.

Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 4, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 5, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 6, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
itamarst added a commit to itamarst/modin that referenced this issue Aug 7, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
devin-petersohn pushed a commit that referenced this issue Aug 11, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
…t#1886)

Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants