Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-dependent on modin.DataFrame utils from modin/pandas/utils.py to modin/utils.py #2054

Closed
dchigarev opened this issue Sep 8, 2020 · 0 comments · Fixed by #2055
Closed

Move non-dependent on modin.DataFrame utils from modin/pandas/utils.py to modin/utils.py #2054

dchigarev opened this issue Sep 8, 2020 · 0 comments · Fixed by #2055
Assignees
@dchigarev
Milestone
0.8.1

Comments

@dchigarev
Copy link
Collaborator

Currently importing anything from modin/pandas/utils.py will trigger the execution of modin/pandas/__init__.py which imports modin/pandas/concat.py in its scope, which in its turn imports BaseQueryCompiler.

So if we want to import some util functions in BaseQueryCompiler we will create a circular import which will lead to an ImportError, because when inside BaseQueryCompiler we want to

from modin.pandas.utils import try_cast_to_pandas

it will trigger to import BaseQueryCompiler inside BaseQueryCompiler
@dchigarev dchigarev added this to the 0.8.1 milestone Sep 8, 2020
@dchigarev dchigarev self-assigned this Sep 8, 2020
@dchigarev dchigarev mentioned this issue Sep 8, 2020
Merged
6 tasks
dchigarev added a commit to dchigarev/modin that referenced this issue Sep 9, 2020
@dchigarev
FIX-modin-project#2054: modin/utils.py created
8c30b81 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev changed the title Move non-dependent on pandas utils from modin/pandas/utils.py to modin/utils.py Move non-dependent on modin.DataFrame utils from modin/pandas/utils.py to modin/utils.py Sep 9, 2020
anmyachev pushed a commit that referenced this issue Sep 9, 2020
@dchigarev
FIX-#2054: Moved non-dependent on modin.DataFrame utils to modin/util…
6140c81 
…s.py (#2055)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@dchigarev @aregm
FIX-modin-project#2054: Moved non-dependent on modin.DataFrame utils …
90e403e 
…to modin/utils.py (modin-project#2055)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

FIX-#2054: Moved non-dependent on modin.DataFrame utils to modin/utils.py dchigarev/modin
1 participant
@dchigarev