-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: indicate order of option items in commit message #2434
Comments
I think the current instructions are clear enough: https://modin.readthedocs.io/en/0.15.3/development/contributing.html#certificate-of-origin-v-1-1 |
If you say so. :) |
@reshamas thank you for responding to this issue even though it's so old! It's a little hard to figure out what the contributing instructions said at the time you reported this issue, because the file has moved around since then. I assumed that there were no instructions about signing commits then. How could we make the current documentation clearer? I assume that readers know that command line flags for commands like |
I believe this issue was inspired by a challenge at an online sprint at PyData Global 2021 with @devin-petersohn. Maybe the best way to see if the instructions are clear is to check again at a sprint or with new contributors. I haven't contributed to modin since last October. |
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
The current instructions are not clear on how
-s
should be included in commit message. This works:git commit -m "message" -s
file: https://github.com/modin-project/modin/blob/master/docs/CONTRIBUTING.rst
The text was updated successfully, but these errors were encountered: