Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: __imul__ uses __add__ instead of __mul__ #7379

Closed
3 tasks done
sfc-gh-joshi opened this issue Aug 30, 2024 · 0 comments · Fixed by #7380
Closed
3 tasks done

BUG: __imul__ uses __add__ instead of __mul__ #7379

sfc-gh-joshi opened this issue Aug 30, 2024 · 0 comments · Fixed by #7380
Labels
bug 🦗 Something isn't working P3 Very minor bugs, or features we can hopefully add some day.

Comments

@sfc-gh-joshi
Copy link

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

import modin.pandas as pd
s = pd.Series([2])
s *= 3

Issue Description

The above code produces a 1-element series containing 5 instead of the expected 6, since a typo in our frontend code aliases __imul__ to __add__ instead of __mul__.

Expected Behavior

Multiply instead of adding.

Error Logs

Replace this line with the error backtrace (if applicable).

Installed Versions

INSTALLED VERSIONS

commit : f70176a
python : 3.10.13.final.0
python-bits : 64
OS : Darwin
OS-release : 23.6.0
Version : Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020
machine : arm64
processor : arm
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

Modin dependencies

modin : 0.31.0+17.gf70176a7
ray : 2.34.0
dask : 2024.8.1
distributed : 2024.8.1

pandas dependencies

pandas : 2.2.2
numpy : 1.26.4
pytz : 2023.3.post1
dateutil : 2.8.2
setuptools : 68.0.0
pip : 23.3
Cython : None
pytest : 8.3.2
hypothesis : None
sphinx : 5.3.0
blosc : None
feather : None
xlsxwriter : None
lxml.etree : 5.3.0
html5lib : None
pymysql : None
psycopg2 : 2.9.9
jinja2 : 3.1.4
IPython : 8.17.2
pandas_datareader : None
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : 4.12.2
bottleneck : None
dataframe-api-compat : None
fastparquet : 2024.5.0
fsspec : 2024.6.1
gcsfs : None
matplotlib : 3.9.2
numba : None
numexpr : 2.10.1
odfpy : None
openpyxl : 3.1.5
pandas_gbq : 0.23.1
pyarrow : 17.0.0
pyreadstat : None
python-calamine : None
pyxlsb : None
s3fs : 2024.6.1
scipy : 1.14.1
sqlalchemy : 2.0.32
tables : 3.10.1
tabulate : None
xarray : 2024.7.0
xlrd : 2.0.1
zstandard : None
tzdata : 2023.3
qtpy : None
pyqt5 : None

@sfc-gh-joshi sfc-gh-joshi added bug 🦗 Something isn't working Triage 🩹 Issues that need triage labels Aug 30, 2024
@noloerino noloerino added P3 Very minor bugs, or features we can hopefully add some day. and removed Triage 🩹 Issues that need triage labels Aug 30, 2024
noloerino added a commit to noloerino/modin that referenced this issue Aug 30, 2024
…ultiplication

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
YarShev pushed a commit that referenced this issue Sep 2, 2024
noloerino added a commit to noloerino/modin that referenced this issue Sep 12, 2024
…hecks

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
noloerino added a commit to noloerino/modin that referenced this issue Sep 17, 2024
…hecks

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
noloerino added a commit to noloerino/modin that referenced this issue Sep 20, 2024
…hecks

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants