Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomly generated redis password for Ray by default #1107

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

devin-petersohn
Copy link
Collaborator

Signed-off-by: Devin Petersohn devin.petersohn@gmail.com

What do these changes do?

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@simon-mo
Copy link
Collaborator

So ray use a default password now. It’s just not randomly generated. Do you need it to be random?

@devin-petersohn
Copy link
Collaborator Author

@simon-mo All Ray instances using the same password does not seem to be very secure to me. Is it enough to secure the instance if everyone can see the password here: https://ray.readthedocs.io/en/latest/package-ref.html#ray.init?

@simon-mo
Copy link
Collaborator

Yeah the ray approach only prevent port scanning attack (given that attacker doesn’t know the user is running ray).

@devin-petersohn devin-petersohn merged commit d54d159 into modin-project:master Feb 26, 2020
@devin-petersohn devin-petersohn deleted the issues/108 branch February 26, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ray] Secure Redis ports
2 participants