REFACTOR-#1741: Use low-level api for kurt function implementation with defined level parameter #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
==========================================
+ Coverage 82.39% 84.03% +1.63%
==========================================
Files 77 77
Lines 7948 7948
==========================================
+ Hits 6549 6679 +130
+ Misses 1399 1269 -130
Continue to review full report at Codecov.
|
|
|
|
|
@amyskov I think we need a issue with example of different behavior |
amyskov
changed the title
amyskov
force-pushed
the
kurt_level_correction
branch
from
97c67d7
to
1e47afc
Compare
Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
amyskov
force-pushed
the
kurt_level_correction
branch
from
1e47afc
to
90b0b26
Compare
|
Current implementation of kurt function with level parameter uses apply version which invokes function on each Series of DataFrame, that is not corresponds with Pandas apply, which calls DataFrame method. Since Modin apply method is reworked in #1718 , behavior kurt with level parameter should be reworked too. |
amyskov
changed the title
anmyachev
approved these changes
Jul 22, 2020
anmyachev
changed the title
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…ementation with defined level parameter (modin-project#1719) Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Sub PR of #1718 , function implementation slightly changed in order to better match Pandas behavior.
flake8 modinblack --check modingit commit -s