Implement numpy autowrapping in remote context #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
- Coverage 83.58% 83.56% -0.02%
==========================================
Files 79 80 +1
Lines 8558 8636 +78
==========================================
+ Hits 7153 7217 +64
- Misses 1405 1419 +14
Continue to review full report at Codecov.
|
|
|
|
anmyachev
requested changes
Jul 28, 2020
There was a problem hiding this comment.
I agree with @anmyachev about docstrings. We also need a documentation page for how this works, so it will be good to add a new issue for it (for next release).
The implementation looks good to me.
|
@vnlitvinov LGTM! Let's wait CI result. |
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
…ke ndarray Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov
force-pushed
the
magic-numbers-everywhere
branch
from
611cd4b
to
e7d9a2f
Compare
anmyachev
approved these changes
Jul 28, 2020
devin-petersohn
approved these changes
Jul 28, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This replaces
numpymodule whenever a user code executesimport numpywith a special class that returns different things in local and remote contexts.It also registers special reducers (support for pickling), as, when trying to pickle an object from "local" numpy when "remote" is activated leads to
TypeError: different classwithout special reducer.Note that access to
numpyis always local formodin.*andpandas.*packages, as NumPy is used internally there and is not needed to be proxied to the remote.flake8 modinblack --check modingit commit -s