FIX-#1497: Don't sort in concat() when sort=False #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
==========================================
+ Coverage 81.39% 81.47% +0.08%
==========================================
Files 79 79
Lines 9165 9178 +13
==========================================
+ Hits 7460 7478 +18
+ Misses 1705 1700 -5
Continue to review full report at Codecov.
|
|
|
|
|
Investigating the failing tests now. |
|
It appears that the decision about when to sort is highly inconsistent within Pandas 😢 |
|
The issue appears to be pandas-dev/pandas#35092 — Pandas has bug where What is the policy for matching Pandas bugs? |
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
@itamarst We try to match pandas behavior when possible. Is Modin behaving as pandas is supposed to after your fixes? In that case, I would say that we can probably just throw a warning linking to the pandas bug until it is resolved and keep the correct behavior. |
|
For
So warning is probably the way to go, but will also have to figure out how to make the |
…gnored. Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
@itamarst That sounds good. In the test, we can check if the result is not sorted, but should be before we sort the pandas side so that we don't accidentally hide any bugs in the future. |
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
OK, done hopefully. |
devin-petersohn
requested changes
Aug 5, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
devin-petersohn
approved these changes
Aug 6, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…-project#1889) Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modinblack --check modingit commit -s