REFACTOR-#1928: move columnarization to backend #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
==========================================
+ Coverage 81.53% 81.61% +0.07%
==========================================
Files 79 79
Lines 9192 9201 +9
==========================================
+ Hits 7495 7509 +14
+ Misses 1697 1692 -5
Continue to review full report at Codecov.
|
|
|
YarShev
requested changes
Aug 14, 2020
|
@ienkovich , can you please create an issue for the PR? |
YarShev
requested changes
Aug 17, 2020
| """ | ||
| Transposes this QueryCompiler if it has a single row but multiple columns. | ||
|
|
||
| This method should be called for QueryCompilers representing a Series object, |
There was a problem hiding this comment.
I don't understand this phrase. You say This method should be called for QueryCompilers representing a Series object, i.e. self.is_series_like() should be True., but you call columnarize without previously is_series_like called. Maybe, worth to delete/change it and is_series_like is not needed at all?
There was a problem hiding this comment.
Currently, columnarize method is called in Series init function only, where we already know data has a proper shape. Before creating Series object we use is_series_like to check the shape. Both functions are used to move index accesses to a backend and provide an alternate implementation in the OmniSci backend, which would be able to avoid index access in certain cases.
ienkovich
changed the title
ienkovich
changed the title
YarShev
requested changes
Aug 18, 2020
| """ | ||
| Transposes this QueryCompiler if it has a single row but multiple columns. | ||
|
|
||
| This method should be called for QueryCompilers representing a Series object, |
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
|
Pushed the rest of docstrings changes. |
|
@ienkovich , thanks, LGTM! |
YarShev
approved these changes
Aug 18, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…roject#1914) Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This patch helps lazy backend to avoid index accesses in Series constructor by moving columnarization part into the backend.
flake8 modinblack --check modingit commit -s