-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda recipe for Modin #1986
Conda recipe for Modin #1986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like anything Intel related, can we remove the Intel Modin title? Or am I missing some Intel related requirements?
Signed-off-by: Anton Malakhov <Anton.Malakhov@intel.com>
Signed-off-by: Anton Malakhov <Anton.Malakhov@intel.com>
8bd776a
to
3f9629d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
- Coverage 81.78% 76.64% -5.14%
==========================================
Files 79 79
Lines 9457 9457
==========================================
- Hits 7734 7248 -486
- Misses 1723 2209 +486
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is this still blocked on #1871?
it is logical continuation or even part of #1871 but can be merged right away if you prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to merge now. Thanks @anton-malakhov
Signed-off-by: Anton Malakhov <Anton.Malakhov@intel.com>
test: | ||
import: | ||
- modin | ||
- modin.experemental.pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not catching this before, should notmodin.experemental.pandas
be modin.experimental.pandas
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should, cc @anton-malakhov
Add conda recipe for Intel Modin releases
flake8 modin
black --check modin
git commit -s