-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#3755: return positional indices for '.indices' GroupBy property #3758
Conversation
…pby property Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #3758 +/- ##
===========================================
- Coverage 85.49% 44.51% -40.99%
===========================================
Files 197 183 -14
Lines 16421 15748 -673
===========================================
- Hits 14039 7010 -7029
- Misses 2382 8738 +6356
Continue to review full report at Codecov.
|
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dchigarev this LGTM!
Signed-off-by: Dmitry Chigarev dmitry.chigarev@intel.com
What do these changes do?
Fixes implementation of the
GroupBy.indices
. Now it properly returns positional indices of the groups, instead of labels-based ones as it was done before. The actual method that computesgroups
andindices
was changed as follows: it was remade from a property (._index_grouped
) to a method (._compute_index_grouped()
) taking a boolean flag, indicating whether to compute positional or labels-based group indices.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
.indices
and.groups
when it shouldn't #3755docs/developer/architecture.rst
is up-to-date