-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4162: Use skipif
instead of skip
for compatibility with pytest 7.0
#4163
Conversation
skipif
instead of skip
for compatibility with pytest 7.0skipif
instead of skip
for compatibility with pytest 7.0
…ity with pytest 7.0 Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Rehan Durrani <rehan@ponder.io>
d0bf452
to
cb28ec8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4163 +/- ##
==========================================
+ Coverage 85.62% 88.46% +2.83%
==========================================
Files 201 201
Lines 16866 16866
==========================================
+ Hits 14442 14920 +478
+ Misses 2424 1946 -478
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides non-related release note. Will merge this after explaining the reasons for it/removing it.
@RehanSD As we want to merge this PR ASAP (the error you're fixing blocks every PR) I've decided to not wait for your response due to 12h timezones lag and so applied the suggested changes by myself. I hope you won't mind 😄 , but if you will then you can do the reverted changes in a different PR. |
Hi @dchigarev! No worries at all - thanks for getting this PR in! |
…ity with pytest 7.0 (modin-project#4163) Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Rehan Durrani rehan@ponder.io
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
skipif
instead ofskip
if providing a condition #4162 ?docs/development/architecture.rst
is up-to-date