-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4213: Refactor modin/examples/tutorial/
directory
#4214
REFACTOR-#4213: Refactor modin/examples/tutorial/
directory
#4214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4214 +/- ##
==========================================
+ Coverage 85.69% 88.63% +2.94%
==========================================
Files 201 201
Lines 16807 16807
==========================================
+ Hits 14402 14897 +495
+ Misses 2405 1910 -495
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I left a comment about some issues we've had with pip, let me know what you think.
using `requirements.txt` file located in the current directory: | ||
|
||
```bash | ||
pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have lately had a hard time with this. Sometimes pip is installing every version. Should we add a comment in this document about manually installing each line in case pip fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should add a note on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on master and added a note.
…ctory Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
40c925b
to
4460d85
Compare
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
4460d85
to
d056bb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ctory (modin-project#4214) Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
modin/examples/tutorial/
directory #4213docs/development/architecture.rst
is up-to-date