-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4322: Move is_reduce_fn outside of groupby_agg. #4323
Merged
YarShev
merged 5 commits into
modin-project:master
from
mvashishtha:4322-move-is-reduce-fn
Mar 16, 2022
Merged
REFACTOR-#4322: Move is_reduce_fn outside of groupby_agg. #4323
YarShev
merged 5 commits into
modin-project:master
from
mvashishtha:4322-move-is-reduce-fn
Mar 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #4323 +/- ##
==========================================
+ Coverage 84.82% 89.53% +4.70%
==========================================
Files 213 214 +1
Lines 17321 17546 +225
==========================================
+ Hits 14693 15709 +1016
+ Misses 2628 1837 -791
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
dchigarev
reviewed
Mar 15, 2022
dchigarev
previously approved these changes
Mar 15, 2022
YarShev
reviewed
Mar 16, 2022
YarShev
reviewed
Mar 16, 2022
YarShev
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
Move
is_reduce_fn
outside of the pandas query compiler'sgroupby_agg
.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date