-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#4359: Add __dataframe__ method to the protocol dataframe #4360
FEAT-#4359: Add __dataframe__ method to the protocol dataframe #4360
Conversation
e30ae82
to
84644bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #4360 +/- ##
==========================================
+ Coverage 87.29% 89.98% +2.69%
==========================================
Files 219 219
Lines 17921 17927 +6
==========================================
+ Hits 15644 16132 +488
+ Misses 2277 1795 -482
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, left a single comment
modin/core/dataframe/base/exchange/dataframe_protocol/dataframe.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge on green CI
…aframe Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
218c4a7
to
ef5ec37
Compare
Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date