-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#4363: Use Ray from pypi in CI #4364
Conversation
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4364 +/- ##
==========================================
+ Coverage 87.29% 87.94% +0.64%
==========================================
Files 219 219
Lines 17921 17921
==========================================
+ Hits 15644 15760 +116
+ Misses 2277 2161 -116
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@devin-petersohn, there is still a seg fault in CI. Should we pip Ray to a lower version? |
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
I wonder how that helps - it effectively uses Ray 1.10, right? |
@vnlitvinov Not sure what is happening with conda to cause this seg fault, but this tests with Ray 1.11 I am not able to reproduce the seg faults locally |
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
I was basing on this line:
|
@vnlitvinov That line was removed in the latest commits. |
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge when CI passes.
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date