FIX-#4370: Fix broken docstring links #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #4375 +/- ##
==========================================
+ Coverage 82.91% 90.02% +7.10%
==========================================
Files 219 219
Lines 17927 17924 -3
==========================================
+ Hits 14865 16136 +1271
+ Misses 3062 1788 -1274
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
|
alexander3774
force-pushed
the
fix_io_links
branch
2 times, most recently
from
c18aaf3
to
5d3eb5c
Compare
alexander3774
commented
Apr 11, 2022
.github/workflows/push-to-master.yml
Outdated
| push: | ||
| branches: | ||
| - master | ||
| on: pull_request |
There was a problem hiding this comment.
Will be returned back after changes are approved (on parameter should be set to pull_request value to ensure that test docs job from push-to-master.yml config is fixed).
alexander3774
commented
Apr 11, 2022
|
PR is ready for review. P.S. PR will remain in the draft state untill changes are approved and changes of CI workflow are reverted. |
YarShev
reviewed
Apr 12, 2022
modin/pandas/general.py
Outdated
| @@ -370,12 +370,32 @@ def unique(values): # noqa: PR01, RT01, D200 | |||
| return Series(values).unique() | |||
|
|
|||
|
|
|||
| @_inherit_docstrings(pandas.value_counts, apilink="pandas.value_counts") | |||
| # adding docstring since pandas docs doesn't have web section for this function | |||
There was a problem hiding this comment.
Please submit a question on this in pandas GH. Same is for other related functions.
There was a problem hiding this comment.
Ok, question was submitted pandas-dev/pandas#46749.
There was a problem hiding this comment.
pandas answered that these functions are considered to be removed in the future releases, so i think we can leave docstrings until these functions are removed from pandas api to drop it in Modin too.
prutskov
reviewed
Apr 12, 2022
alexander3774
force-pushed
the
fix_io_links
branch
from
0dbffc2
to
2faeac6
Compare
Signed-off-by: alexander3774 <myskova977@gmail.com>
Signed-off-by: alexander3774 <myskova977@gmail.com>
Co-authored-by: Alexey Prutskov <lehaprutskov@gmail.com> Signed-off-by: alexander3774 <myskova977@gmail.com>
Signed-off-by: alexander3774 <myskova977@gmail.com>
Co-authored-by: Alexey Prutskov <lehaprutskov@gmail.com>
Signed-off-by: alexander3774 <myskova977@gmail.com>
alexander3774
force-pushed
the
fix_io_links
branch
from
ce0827a
to
6306ac3
Compare
|
LGTM! Triggered CI. |
|
test-ray-client is failing now and tracked by #4383. |
Signed-off-by: alexander3774 <myskova977@gmail.com>
Yes, i see. Target P.S. please trigger CI. |
YarShev
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alexander3774 myskova977@gmail.com
What do these changes do?
This PR fixes failed
test docsCI job.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date