-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4373: Fix invalid file path when trying read_csv_glob
with usecols
parameter
#4405
Conversation
…arameter Signed-off-by: Anatoly Myachev <anatoliimyachev@mail.com>
read_csv_glob
with usecols
parameter
@@ -138,7 +138,7 @@ def _read(cls, filepath_or_buffer, **kwargs): | |||
if usecols is not None and usecols_md[1] != "integer": | |||
del kwargs["usecols"] | |||
all_cols = pandas.read_csv( | |||
OpenFile(filepath_or_buffer, "rb"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to use OpenFile
function here, pandas
will handle itself.
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
==========================================
+ Coverage 86.74% 89.46% +2.72%
==========================================
Files 222 222
Lines 18042 18042
==========================================
+ Hits 15650 16142 +492
+ Misses 2392 1900 -492
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Anatoly Myachev anatoliimyachev@mail.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
read_csv_glob
withusecols
parameter #4373docs/development/architecture.rst
is up-to-date