-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4566: Pin Ray < 1.13.0 to avoid deserialization race condition. #4567
FIX-#4566: Pin Ray < 1.13.0 to avoid deserialization race condition. #4567
Conversation
…e condition. Signed-off-by: mvashishtha <mahesh@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #4567 +/- ##
===========================================
- Coverage 86.34% 71.18% -15.16%
===========================================
Files 228 229 +1
Lines 18438 18715 +277
===========================================
- Hits 15920 13323 -2597
- Misses 2518 5392 +2874
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a condition on the upper ray bound here?
Line 94 in ba2b6ea
if version.parse(ray.__version__) < MIN_RAY_VERSION: |
Signed-off-by: mvashishtha <mahesh@ponder.io>
Is this superseded by #4568 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvashishtha doc build is failing because changes here are not compatible with docs/requirements-doc.txt
. For some reason that is installing from the github.
This probably needs to change: modin/docs/requirements-doc.txt Line 12 in d5ff94e
|
@devin-petersohn I saw that failure, but what should we change it to? How can we install modin using requirements from the current PR? |
@mvashishtha will you delete that line and see if that fixes it? |
…version of ray. Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
@devin-petersohn that didn't work either. "Build docs" gives |
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date